Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align on config name for use import access level #35

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jan 24, 2025

Motivation:

When the plugin was done we went through a few iterations of the shape of config and settled on accessLevelOnImports vs. useAccessLevelOnImports but that change wasn't made.

Modifications:

  • Update config name.

Result:

API is what we planned it to be.

Motivation:

When the plugin was done we went through a few iterations of the shape
of config and settled on `accessLevelOnImports` vs.
`useAccessLevelOnImports` but that change wasn't made.

Modifications:

- Update config name.

Result:

API is what we planned it to be.
@glbrntt glbrntt requested a review from rnro January 24, 2025 09:00
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Jan 24, 2025
Copy link
Collaborator

@rnro rnro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks George!

@glbrntt glbrntt enabled auto-merge (squash) January 24, 2025 10:39
@glbrntt glbrntt merged commit 7695d98 into grpc:main Jan 24, 2025
21 checks passed
@glbrntt glbrntt deleted the access-level-on-imports branch January 24, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants