Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings about unused value in plugin error #33

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jan 22, 2025

Motivation:

The plugin error case for an incompatible target has an associated value which is currently ignored.

Modifications:

  • Use the value

Result:

Fewer warnings

Motivation:

The plugin error case for an incompatible target has an associated value
which is currently ignored.

Modifications:

- Use the value

Result:

Fewer warnings
@glbrntt glbrntt requested a review from rnro January 22, 2025 11:00
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Jan 22, 2025
@glbrntt glbrntt changed the title Fix warns about unused value in plugin error Fix warnings about unused value in plugin error Jan 22, 2025
@glbrntt glbrntt merged commit 05334bb into grpc:main Jan 22, 2025
22 checks passed
@glbrntt glbrntt deleted the avoid-warning branch January 22, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants