binder: stops emulating for 21/22 Lollipop in tests #12164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See cl/769936336 internally
zhangkun83
changed the title
ejona86
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
The title is misleading, as the minSdkVersion is still 21. This just stops emulating certain environments in tests. When merging, can you make that more clear?
Sure wish robolectric documented that value so what know what value it will match...
https://robolectric.org/javadoc/4.5/org/robolectric/annotation/Config.html#OLDEST_SDK. #11474 is still open to drop older API versions more widely. Dropping it from the tests early doesn't seem like it'd be a concern.
zhangkun83
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cl/769936336 internally