Move all test helper classes out of AbstractTransportTest so they can be used elsewhere#12125
Merged
kannanjgithub merged 11 commits intogrpc:masterfrom Jun 5, 2025
Merged
Move all test helper classes out of AbstractTransportTest so they can be used elsewhere#12125kannanjgithub merged 11 commits intogrpc:masterfrom
kannanjgithub merged 11 commits intogrpc:masterfrom
Conversation
| MockServerTransportListener create(ServerTransport transport); | ||
| } | ||
|
|
||
| public MockServerListener(ServerTransportListenerFactory serverTransportListenerFactory) { |
Contributor
There was a problem hiding this comment.
Note to other reviewers: This is the new logic apart from simple refactoring changes, to take a factory for the transport listener whereas the original inner class was using a hardcoded implementation (MockServerTransportListener) by itself.
kannanjgithub
approved these changes
Jun 3, 2025
AgraVator
pushed a commit
to AgraVator/grpc-java
that referenced
this pull request
Jun 23, 2025
… be used elsewhere (grpc#12125)
jdcormie
added a commit
to jdcormie/grpc-java
that referenced
this pull request
Jun 27, 2025
… be used elsewhere (grpc#12125)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10845