Android: Add failOnWarnings check to android build.gradle and configure lint as warnings as error #12040
Conversation
…re lint as warnings as error
|
@vinodhabib Please review and share feedback on any changes or improvements needed. |
There was a problem hiding this comment.
You've done both (linter warnings and enabling -Werror) the mentioned issues in this PR. That's fine for me. @ejona86 should be able to tell us if we shouldn't be doing like this.
android/build.gradle
Outdated
| lintOptions { abortOnError true } | ||
|
|
||
| // fail on android lint warnings if failOnWarning is set true | ||
| lintOptions { |
There was a problem hiding this comment.
If we are doing this anyway, lintOptions is deprecated. Use lint instead. (Wait for Eric's comment on this before working)
android/build.gradle
Outdated
| @@ -44,6 +52,14 @@ dependencies { | |||
| testImplementation libraries.truth | |||
| } | |||
|
|
|||
| // Enforce -Werror on java compiler if failOnWarning is set | |||
There was a problem hiding this comment.
You may remove the comments as they are self explanatory.
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
android/build.gradle
Outdated
There was a problem hiding this comment.
This is adding it to grpc-android only. We actually want this on all android-related builds, which would include android-interop-testing, binder, and cronet as well. For that, the configuration should go in build.gradle and activate when the plugins com.android.application or com.android.library are used. You would use plugins.withId() for that, similar to the existing plugins.withId("java") and similar blocks. The easiest way may be to use plugins.withId("com.android.base"), which is the base plugin for both library and application.
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
|
@ejona86 you're right - lint was an additional improvement, but I missed re-adding the JavaCompile configuration from the original intent of #6868. Initially I assumed that configuring tasks.withType(JavaCompile) globally already applied -Xlint:all and -Werror across all modules. I've now updated the PR to include both the lint block and the JavaCompile warnings, so all modules are covered. Please take another look, thanks! |
Android: Add failOnWarnings check to android build.gradle and configure lint as warnings as error.
Fixes: #6868