-
Notifications
You must be signed in to change notification settings - Fork 4.6k
transport/client: Return status code Unknown on missing grpc-status
#8702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transport/client: Return status code Unknown on missing grpc-status
#8702
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8702 +/- ##
==========================================
- Coverage 83.29% 83.23% -0.06%
==========================================
Files 416 416
Lines 32267 32267
==========================================
- Hits 26876 26858 -18
- Misses 4017 4028 +11
- Partials 1374 1381 +7
🚀 New features to boost your workflow:
|
Unknown on missing or unparsable grpc-status
We want to first undo the status code change made in #8548, do the release and then make the other status code change after the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title and make sure the commit matches [EDIT: when merging].
Also please add more explanation for this change in the PR description. In this case we should explain why we are making this change and link to the PR that introduced the behavior change we are reverting.
easwars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo actions required for Doug's final comments.
This doesn't seem to have happened. So now the commit says "unparsable grpc-status" but we are still returning Internal on an unparsable status.
This can still be done. Please edit the description and PR title appropriately. |
Unknown on missing or unparsable grpc-statusUnknown on missing grpc-status
|
I updated the title and the description for posterity. |
…us (grpc#8702) See https://github.com/grpc/grpc/blob/master/doc/statuscodes.md for more details. RELEASE NOTES: * transport/client : Return Unknown on missing or unparsable grpc-status.
#8548 changed the grpc status code returned on missing
grpc-statusheader toInternal. This PR changes it back toUnknownas that is the expected behavior.See https://github.com/grpc/grpc/blob/master/doc/statuscodes.md for more details. Here
Unknownis defined as follows:RELEASE NOTES:
Unknownon missing grpc-status.