Skip to content

Conversation

@mbissa
Copy link
Contributor

@mbissa mbissa commented Nov 12, 2025

#8548 changed the grpc status code returned on missing grpc-status header to Internal. This PR changes it back to Unknown as that is the expected behavior.

See https://github.com/grpc/grpc/blob/master/doc/statuscodes.md for more details. Here Unknown is defined as follows:

Unknown error. For example, this error may be returned when a Status value received 
from another address space belongs to an error space that is not known in this 
address space. Also errors raised by APIs that do not return enough error information
may be converted to this error.

RELEASE NOTES:

  • transport/client : Return status code Unknown on missing grpc-status.

@mbissa mbissa added this to the 1.77 Release milestone Nov 12, 2025
@mbissa mbissa requested review from dfawley and easwars November 12, 2025 00:02
@mbissa mbissa assigned mbissa and easwars and unassigned mbissa Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.23%. Comparing base (e816736) to head (7a7b596).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8702      +/-   ##
==========================================
- Coverage   83.29%   83.23%   -0.06%     
==========================================
  Files         416      416              
  Lines       32267    32267              
==========================================
- Hits        26876    26858      -18     
- Misses       4017     4028      +11     
- Partials     1374     1381       +7     
Files with missing lines Coverage Δ
internal/transport/http2_client.go 92.61% <100.00%> (+0.19%) ⬆️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@easwars easwars changed the title transport/client : correcting status code to Unknown for missing grpc code transport/client: Return Unknown on missing or unparsable grpc-status Nov 12, 2025
easwars
easwars previously approved these changes Nov 12, 2025
@dfawley dfawley assigned mbissa and unassigned easwars and dfawley Nov 12, 2025
@easwars easwars dismissed their stale review November 12, 2025 19:15

We want to first undo the status code change made in #8548, do the release and then make the other status code change after the release.

@mbissa mbissa assigned easwars and dfawley and unassigned mbissa Nov 13, 2025
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title and make sure the commit matches [EDIT: when merging].

Also please add more explanation for this change in the PR description. In this case we should explain why we are making this change and link to the PR that introduced the behavior change we are reverting.

@dfawley dfawley assigned mbissa and unassigned dfawley Nov 13, 2025
Copy link
Contributor

@easwars easwars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo actions required for Doug's final comments.

@easwars easwars removed their assignment Nov 13, 2025
@mbissa mbissa merged commit f191b45 into grpc:master Nov 14, 2025
14 checks passed
@dfawley
Copy link
Member

dfawley commented Nov 14, 2025

@mbissa

Please update the PR title and make sure the commit matches [EDIT: when merging].

This doesn't seem to have happened. So now the commit says "unparsable grpc-status" but we are still returning Internal on an unparsable status.

Also please add more explanation for this change in the PR description. In this case we should explain why we are making this change and link to the PR that introduced the behavior change we are reverting.

This can still be done. Please edit the description and PR title appropriately.

@easwars easwars changed the title transport/client: Return Unknown on missing or unparsable grpc-status transport/client: Return status code Unknown on missing grpc-status Nov 14, 2025
@easwars
Copy link
Contributor

easwars commented Nov 14, 2025

I updated the title and the description for posterity.

easwars pushed a commit to easwars/grpc-go that referenced this pull request Nov 14, 2025
…us (grpc#8702)

See https://github.com/grpc/grpc/blob/master/doc/statuscodes.md for more
details.

RELEASE NOTES:
* transport/client : Return Unknown on missing or unparsable
grpc-status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants