-
Notifications
You must be signed in to change notification settings - Fork 4.5k
interop: improve rpc_soak and channel_soak test to cover concurrency in Go #7926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7926 +/- ##
==========================================
- Coverage 82.04% 82.02% -0.03%
==========================================
Files 377 381 +4
Lines 38180 38539 +359
==========================================
+ Hits 31326 31612 +286
- Misses 5551 5609 +58
- Partials 1303 1318 +15 |
townba
reviewed
Dec 13, 2024
dfawley
reviewed
Dec 16, 2024
dfawley
reviewed
Jan 9, 2025
dfawley
approved these changes
Jan 9, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Jan 26, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Jan 26, 2025
purnesh42H
added a commit
to purnesh42H/grpc-go
that referenced
this pull request
Jan 30, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 13, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 13, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 13, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Interop
Includes vanilla and PSM interop test client and server. Not for bugs from interop testing.
Type: Testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES:
This PR aims to enhance the test coverage of the C2P E2E load test by improving the rpc_soak and channel_soak tests to support concurrency in Go. The updated logic closely follows the approach used in the Java implementation, which has already been merged.
rpc_soak:
The client performs many large_unary RPCs in sequence over the same channel. The test can run in either a concurrent or non-concurrent mode, depending on the number of threads specified (soak_num_threads).
channel_soak:
Similar to rpc_soak, but this time each RPC is performed on a new channel. The channel is created just before each RPC and is destroyed just after.
Note on Concurrent Execution and Channel Creation:
In a concurrent execution setting (i.e., when soak_num_threads > 1), each thread performs a portion of the total soak_iterations and creates and destroys its own channel for each RPC iteration.
Thread-specific logs will include the thread_id, helping to track performance across threads, especially when each thread is managing its own channel lifecycle.
@townba
@dfawley