Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: fix receiving empty messages when compression is enabled and maxReceiveMessageSize is maxInt64 #7753 #7918

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

vinothkumarr227
Copy link

@vinothkumarr227 vinothkumarr227 commented Dec 10, 2024

Fixes #4552

RELEASE NOTES:

  • grpc: fix receiving empty messages when compression is enabled and maxReceiveMessageSize is maxInt64

@arjan-bal arjan-bal self-requested a review December 11, 2024 11:09
@arjan-bal arjan-bal self-assigned this Dec 11, 2024
@arjan-bal arjan-bal added Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. Type: Bug and removed Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. labels Dec 11, 2024
@arjan-bal arjan-bal added this to the 1.70 Release milestone Dec 11, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.12%. Comparing base (4c07bca) to head (19686ab).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7918      +/-   ##
==========================================
+ Coverage   81.84%   82.12%   +0.27%     
==========================================
  Files         377      378       +1     
  Lines       38120    38269     +149     
==========================================
+ Hits        31201    31428     +227     
+ Misses       5603     5542      -61     
+ Partials     1316     1299      -17     
Files with missing lines Coverage Δ
rpc_util.go 79.89% <100.00%> (+0.57%) ⬆️

... and 38 files with indirect coverage changes

rpc_util.go Outdated Show resolved Hide resolved
rpc_util.go Outdated Show resolved Hide resolved
rpc_util.go Outdated Show resolved Hide resolved
rpc_util.go Outdated Show resolved Hide resolved
rpc_util.go Outdated Show resolved Hide resolved
rpc_util.go Outdated Show resolved Hide resolved
rpc_util.go Outdated Show resolved Hide resolved
rpc_util.go Outdated Show resolved Hide resolved
rpc_util.go Outdated Show resolved Hide resolved
rpc_util.go Outdated Show resolved Hide resolved
rpc_util.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
@vinothkumarr227 vinothkumarr227 force-pushed the 4552-max-receive-message-size-decompression branch from 9d80990 to 3cf9054 Compare December 18, 2024 07:44
rpc_util.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
rpc_util_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get empty response when compress enabled and maxReceiveMessageSize be maxInt64
3 participants