-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: fix receiving empty messages when compression is enabled and maxReceiveMessageSize is maxInt64 #7753 #7918
Open
vinothkumarr227
wants to merge
10
commits into
grpc:master
Choose a base branch
from
vinothkumarr227:4552-max-receive-message-size-decompression
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
added
Area: RPC Features
Includes Compression, Encoding, Attributes/Metadata, Interceptors.
Type: Bug
and removed
Area: RPC Features
Includes Compression, Encoding, Attributes/Metadata, Interceptors.
labels
Dec 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7918 +/- ##
==========================================
+ Coverage 81.84% 82.12% +0.27%
==========================================
Files 377 378 +1
Lines 38120 38269 +149
==========================================
+ Hits 31201 31428 +227
+ Misses 5603 5542 -61
+ Partials 1316 1299 -17
|
arjan-bal
reviewed
Dec 12, 2024
arjan-bal
assigned vinothkumarr227 and arjan-bal and unassigned arjan-bal and vinothkumarr227
Dec 12, 2024
arjan-bal
reviewed
Dec 13, 2024
arjan-bal
assigned vinothkumarr227 and arjan-bal and unassigned arjan-bal and vinothkumarr227
Dec 13, 2024
arjan-bal
reviewed
Dec 17, 2024
arjan-bal
reviewed
Dec 17, 2024
vinothkumarr227
force-pushed
the
4552-max-receive-message-size-decompression
branch
from
December 18, 2024 07:44
9d80990
to
3cf9054
Compare
arjan-bal
reviewed
Dec 18, 2024
arjan-bal
reviewed
Dec 18, 2024
arjan-bal
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4552
RELEASE NOTES: