Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc_util: fix decompress overflow #6120

Closed
wants to merge 2 commits into from
Closed

rpc_util: fix decompress overflow #6120

wants to merge 2 commits into from

Conversation

catundercar
Copy link

@catundercar catundercar commented Mar 15, 2023 •
edited
Loading

This PR aims to fix decompress overflow.
When use gzip and call with MaxCallRecvMsgSize(math.MaxInt64), the LimitReader.N will overflow. It will make buf can not read any bytes.
Related issues:
#6119

RELEASE NOTES: none

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 15, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: catundercar / name: CatUnderCar (33f16b8)

@easwars easwars modified the milestones: 1.54 Release, 1.55 Release Mar 17, 2023
@zasweq zasweq requested a review from easwars March 21, 2023 17:47
@zasweq zasweq requested review from dfawley and removed request for easwars March 21, 2023 17:47
@zasweq zasweq assigned dfawley and unassigned easwars Mar 21, 2023
@dfawley
Copy link
Member

dfawley commented Mar 21, 2023

I believe the code that we already have is correct, and this is not a proper fix. If we want to change anything, maybe change the DialOption and ServerOption for this setting so that they cap the value at math.MaxInt64-1?

@dfawley dfawley assigned catundercar and unassigned dfawley Mar 21, 2023
@github-actions
Copy link

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

@github-actions github-actions bot added the stale label Mar 27, 2023
@github-actions github-actions bot closed this Apr 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley Awaiting requested review from dfawley

Assignees

@catundercar catundercar

Labels
stale Status: Requires Reporter Clarification
Projects
None yet
Milestone
1.55 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@catundercar @dfawley @easwars