-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade validator. #465
base: main
Are you sure you want to change the base?
Upgrade validator. #465
Conversation
protoc-gen-validate is release under the v0.6.2: https://github.com/envoyproxy/protoc-gen-validate/releases/tag/v0.6.2 The release contains the merge PR about "multi-error validation with ValidateAll()": bufbuild/protoc-gen-validate#468
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not version this anywhere? Someone else could come along and regenerate these files with their own version. We should version the generator somewhere.
Do you mean this file |
Sorry, I mean the version of the generator that generates the file. The versions of |
sorry for the noise, but what's the status here? Would be great to have this merged 🎉 |
We added support for |
yes, it's about that 👍 I didn't know about v2 yet, is that usable yet? |
It should be useable, yeah, but we haven't made stable release version of it yet. There are a few oustanding issues still 😬. https://github.com/grpc-ecosystem/go-grpc-middleware/issues?q=is%3Aissue+is%3Aopen+v2+label%3Av2 |
protoc-gen-validate is release under the v0.6.2:
https://github.com/envoyproxy/protoc-gen-validate/releases/tag/v0.6.2
The release contains the merge PR about "multi-error validation with
ValidateAll()":
bufbuild/protoc-gen-validate#468