fix(security): harden Cloud Task callback dispatch - #1724
fix(security): harden Cloud Task callback dispatch#1724groupthinking with Copilot wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
| f"(async={request.async_processing}, priority={request.priority})" | ||
| "🎬 Cloud processing request: %s (async=%s, priority=%s)", | ||
| _sanitize_log_value(request.video_url), | ||
| request.async_processing, |
| "🎬 Cloud processing request: %s (async=%s, priority=%s)", | ||
| _sanitize_log_value(request.video_url), | ||
| request.async_processing, | ||
| request.priority, |
|
Backlog triage: leaving open. Needed for #1876 (DNS rebinding / callback SSRF). CONFLICTING vs rewritten |
|
Please add a See governance: #898 |
Canonical issue
Outcome
Cloud Task callbacks reject SSRF destinations and log-forging input while retaining public HTTP(S) callback delivery.
Scope
Risk
21cfb343.Verification
pytest tests/unit/test_cloud_routes.py -q --no-cov(104 passed) on21cfb343Production evidence
Not applicable: this is a Python callback path; Vercel previews build
apps/weband are non-authoritative.Agent handoff