Replace 'wsdiscovery' and 'onvif-zeep' with 'onvif-python' for better ONVIF device discovery and device handling #89
Replace 'wsdiscovery' and 'onvif-zeep' with 'onvif-python' for better ONVIF device discovery and device handling #89kaburagisec wants to merge 4 commits intogroundlight:mainfrom
Conversation
… ONVIF device discovery and device handling
src/framegrab/rtsp_discovery.py
Outdated
| except Exception as e: | ||
| logger.error(f"Error discovering device: {e}", exc_info=True) | ||
| #ONVIFDiscovery no need to stop, because it closes sockets automatically | ||
| #wsd.stop() # This is supposed to clean up the threads but it doesn't seem to work, sock is still open after running this |
There was a problem hiding this comment.
This line should be removed
There was a problem hiding this comment.
I was thinking of the the commented out line of code in particular
src/framegrab/grabber.py
Outdated
| # will run the following | ||
| # I made a PR to fix this aspect of python-ws-discovery: https://github.com/andreikop/python-ws-discovery/pull/89 | ||
| root_logger = logging.getLogger() | ||
| if root_logger.hasHandlers(): |
There was a problem hiding this comment.
I'm guessing this part could be removed, since it was only added as a hack to work around an issue with wsdiscovery.
|
I think this PR seems reasonable. I will need to validate it internally here before we can decide to merge it in. Out of curiosity, what motivated this change? Did you find something lacking about the |
I just want more implementations for the onvif-python library I built. And I can guarantee the quality of the library. You can ask me anything about it. And regarding wsdiscovery, if it's only for ONVIF device discovery, I don't think there's any need for additional libraries. |
2 participants
wsdiscoveryandonvif-zeepdependencies withonvif-pythonWSDiscoverytoONVIFDiscoveryAPIONVIFCameratoONVIFClientONVIFDiscoveryinstead ofWSDiscoveryThis change improves ONVIF device discovery reliability and reduces dependency conflicts while maintaining backward compatibility.