-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minio to v8.0.0 #991
Bump minio to v8.0.0 #991
Conversation
Hi! Thanks for your contribution, looking forward to seeing this PR ready! :)
Are you sure? I know previous releases of Grist included minio-js in version 7.0.X which was not compatible with node 20, but now with minio v7.1.3, I am able to build grist using node in version 20.13.1. And the package.json file of the library seems to allow that. What error do you get? |
@fflorent Thanks for pointing it out - I seem to be wrong. I was working on Grist Desktop (formerly grist-electron) and I vaguely remember that |
b2f87fa
to
6995a4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good, glad the changes were almost entirely around typing and not substance. One question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SleepyLeslie !
I looked through the code review checklist and the only issue I see is the need to update grist-saas packaging, which is already on @jordigh's radar and we don't have a very graceful way to handle :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Globally sounds good to me, I will take a second and deeper look tomorrow :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @SleepyLeslie!
Do you think there are some changes that are not tracked in the minio-js library we could send them in PRs? So it may benefit to everyone and hopefully help us remove the workarounds
@fflorent Yes, I am already contacting the minio-js team to resolve some issues with their typing. See minio/minio-js#1296 |
minio v7.1.3 only works with Node up to v18. Using the latest v8.0.0 enables building grist-core with Node v20.