Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More readable Document settings #1376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: More readable Document settings #1376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/client/ui/AdminPanelCss.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ const cssItem = styled('div', `

const cssItemShort = styled('div', `
display: flex;
flex-wrap: wrap;
flex-wrap: nowrap;
align-items: center;
padding: 8px;
margin: 0 -8px;
Expand All @@ -131,7 +131,7 @@ const cssItemShort = styled('div', `
`);

const cssItemName = styled('div', `
width: 150px;
width: 230px;
font-weight: bold;
display: flex;
align-items: center;
Expand Down Expand Up @@ -159,6 +159,7 @@ const cssItemName = styled('div', `
`);

const cssItemDescription = styled('div', `
max-width: 250px;
margin-right: auto;
margin-bottom: -1px; /* aligns with the value */
`);
Expand Down
10 changes: 7 additions & 3 deletions app/client/ui/DocumentSettings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export class DocSettingsPage extends Disposable {
const isDocEditor = isOwnerOrEditor(docPageModel.currentDoc.get());

return cssContainer(
dom.create(AdminSection, t('Document Settings'), [
dom.create(cssAdminSection, t('Document Settings'), [
dom.create(AdminSectionItem, {
id: 'timezone',
name: t('Time Zone'),
Expand All @@ -87,7 +87,7 @@ export class DocSettingsPage extends Disposable {
}),
]),

dom.create(AdminSection, t('Data Engine'), [
dom.create(cssAdminSection, t('Data Engine'), [
dom.create(AdminSectionItem, {
id: 'timings',
name: t('Formula timer'),
Expand Down Expand Up @@ -137,7 +137,7 @@ export class DocSettingsPage extends Disposable {
}) : null,
]),

dom.create(AdminSection, t('API'), [
dom.create(cssAdminSection, t('API'), [
dom.create(AdminSectionItem, {
id: 'documentId',
name: t('Document ID'),
Expand Down Expand Up @@ -509,3 +509,7 @@ const cssWrap = styled('p', `
const cssRedText = styled('span', `
color: ${theme.errorText};
`);

const cssAdminSection = styled(AdminSection, `
max-width: 750px;
`);
Loading