Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC issuer behind a proxy cannot be accessed #1363

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+36 −1
Open

OIDC issuer behind a proxy cannot be accessed #1363

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3025f07
OIDC issuer behind a proxy cannot be accessed
tristanrobert Jan 6, 2025
337859a
fixes oidc config test
tristanrobert Jan 6, 2025
e15d5e5
OIDC issuer behind a proxy cannot be accessed
tristanrobert Jan 8, 2025
743f78d
Merge branch 'gristlabs:main' into tristanrobert/issue942
tristanrobert Jan 8, 2025
0584b85
Update app/server/lib/OIDCConfig.ts
tristanrobert Jan 10, 2025
b4e0a4e
Update test/server/lib/OIDCConfig.ts
tristanrobert Jan 10, 2025
0b45e5c
Update test/server/lib/OIDCConfig.ts
tristanrobert Jan 10, 2025
19f556d
OIDC issuer behind a proxy cannot be accessed
Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/server/lib/OIDCConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ import { StringUnionError } from 'app/common/StringUnion';
import { EnabledProtection, EnabledProtectionString, ProtectionsManager } from './oidc/Protections';
import { SessionObj } from './BrowserSession';
import { getOriginUrl } from './requestUtils';
import { proxyAgent } from './ProxyAgent';

const CALLBACK_URL = '/oauth2/callback';

Expand Down Expand Up @@ -181,6 +182,7 @@ export class OIDCConfig {

this._redirectUrl = new URL(CALLBACK_URL, spHost).href;
custom.setHttpOptionsDefaults({
agent: issuerUrl !== undefined ? proxyAgent(new URL(issuerUrl)) : undefined,
...(httpTimeout !== undefined ? {timeout: httpTimeout} : {}),
});
await this._initClient({ issuerUrl, clientId, clientSecret, extraMetadata });
Expand Down
Loading