Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init react wrapper creation #2783

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

damien-schneider
Copy link
Contributor

Related Issue

#2002

Description

This PR initiates the creation of a React wrapper for Gridstack.

I’ve been using a similar wrapper in production in one of my applications. While it functions, there are still a few bugs, such as issues when unmounting components and accessing the API (e.g., grid?.getFloat for displaying dynamic values). With this draft pull request, I aim to collaborate and build a more stable, easy-to-use React wrapper.

To aid development, I’ve set up a Vite environment for the demo, making it easier to test and update the wrapper.

I’m also unsure how to best integrate this wrapper into the main Gridstack library, similar to the Angular integration. This PR will serve as a starting point for achieving that.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
Copy link
Member

hey thank you for starting this... I'll take a look over the weekend when I have more time. But yeah once we have somehting solid we can include as part of the release like the Angular wrapper.

@wallynm
Copy link

wallynm commented Sep 23, 2024

I've tried this PR locally and works nice, features as nested grids should be implemented/exposed by the native gridstack core, right? At least i've had some trouble making they work correctly.

@adumesny adumesny marked this pull request as ready for review September 28, 2024 19:02
@adumesny
Copy link
Member

let's get this in an iterate. haven't had time to check it in detail yet...

@adumesny adumesny merged commit 527ebc5 into gridstack:master Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants