Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation instructions for tools.deps. #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seabass-labrax
Copy link

This pull request adds instructions for installing clj-cbor as a dependency with tools.deps; it uses a different format to Leiningen.

@codecov-commenter
Copy link

Codecov Report

Merging #18 (5f8ea51) into main (2ba843a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files          13       13           
  Lines         890      890           
  Branches        3        3           
=======================================
  Hits          887      887           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba843a...5f8ea51. Read the comment docs.

@greglook greglook self-assigned this Jan 21, 2022

[![Clojars Project](http://clojars.org/mvxcvi/clj-cbor/latest-version.svg)](http://clojars.org/mvxcvi/clj-cbor)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like addition of the tools.deps instructions, but I'm loathe to lose the automatic release version from the banner here. Maybe clojars has a tools.deps-style banner we could show too? If not, I'd prefer the tools.deps section to use a "RELEASE" placeholder or instruct the reader to use the version shown here.

@seabass-labrax
Copy link
Author

Thanks for taking a look at this pull request! I agree; the Clojars banner is pretty neat. Clojars doesn't have a tools.deps banner, but I think it would be a fun project to add that feature to Clojars at some point... I'll look into that :)

How about I amend the commit by moving the Clojars banner up to the start of the README instead of removing it? That way it'd be underneath the other badges and the installation instructions would be as they are in my patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants