-
Notifications
You must be signed in to change notification settings - Fork 96
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(monorepo): avoid fetching infos for internal dependencies
yarn monorepos are identified by packageJson.workspaceRoot. if we are handling one of those, we might encounter a [sub-] package.json that specifies a dependency like this: "@reponame/dependency": "*" which looks like a scoped npm dependency, but is in reality a in-monorepo dependency. For those dependencies, we should not try to fetch infos from npm, because the dependencies are not there.
- Loading branch information
Showing
3 changed files
with
92 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`initial branch utils getDependenciesFromPackageFiles duplicate dependency across dep type 1`] = ` | ||
Array [ | ||
Object { | ||
"name": "@finnpauls/dep", | ||
"type": "devDependencies", | ||
"version": "1.0.0", | ||
}, | ||
] | ||
`; | ||
|
||
exports[`initial branch utils getDependenciesFromPackageFiles single devDependency 1`] = ` | ||
Array [ | ||
Object { | ||
"name": "@finnpauls/dep", | ||
"type": "devDependencies", | ||
"version": "1.0.0", | ||
}, | ||
] | ||
`; | ||
|
||
exports[`initial branch utils getDependenciesFromPackageFiles workspace 1`] = ` | ||
Array [ | ||
Object { | ||
"name": "@finnpauls/blup", | ||
"type": "devDependencies", | ||
"version": "1.0.0", | ||
}, | ||
Object { | ||
"name": "florp", | ||
"type": "dependencies", | ||
"version": "1.2.3", | ||
}, | ||
] | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters