Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline QC markdown analysis added #5

Merged
merged 10 commits into from
Feb 3, 2021
Merged

pipeline QC markdown analysis added #5

merged 10 commits into from
Feb 3, 2021

Conversation

nrosed
Copy link
Collaborator

@nrosed nrosed commented Feb 2, 2021

Here is an overview of the code that changed. The biggest thing is the pipeline QC analysis, other file changes are to fix bugs found via the pipeline.

  • analysis_scripts/qc_scripts/pipeline_qc.md
    • here is the analysis to compare stable statistics across the years to help identify possible issues
  • utils/scraper_processing_utils.R
    • unexpected empty file handling added. this fixed location-identification bugs
  • analysis_scripts/analyze_quote_data/location-analysis_all_years.Rmd
    • place holder file, will add analysis soon

@nrosed nrosed requested a review from danich1 February 2, 2021 01:05
Copy link
Contributor

@danich1 danich1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job on the bug hunting. Two quick questions and then feel free to merge.

@nrosed nrosed merged commit 912b366 into greenelab:main Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants