Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust scanner preferences #1615

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Adjust scanner preferences #1615

wants to merge 2 commits into from

Conversation

Kraemii
Copy link
Member

@Kraemii Kraemii commented Apr 3, 2024 •
edited
Loading

This PR contains two changes to the API:

  1. Rename scanner_preferences to scan_preferences within the Scan json
  2. Change the contents of scan_preferences to a json dict instead of an array of id-value pairs

This PR should be merged for the next major release.

Jira: SC-1040

@Kraemii Kraemii requested a review from a team as a code owner April 3, 2024 16:06
@Kraemii Kraemii mentioned this pull request Apr 3, 2024
Merged
Kraemii added 2 commits April 10, 2024 11:33
@Kraemii
Change: rename scanner_preferences -> scan_preferences
f59fd17 
For backwards compatability, the alias scanner_preferences can still be used
@Kraemii
Change: use a json dict instead of an array of id-value pairs for sca…
5f9f21b 
…n_preferences
@Kraemii Kraemii force-pushed the adjust-scanner-preferences branch from 5d6788f to 5f9f21b Compare April 10, 2024 09:33
@ArnoStiefvater ArnoStiefvater marked this pull request as draft April 17, 2024 08:56
@Kraemii Kraemii added the major_release creates a major release label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
major_release creates a major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Kraemii