Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: The report now has the full size (no longer zero bytes). #2130

Closed
wants to merge 2 commits into from

Conversation

jhelmold
Copy link
Member

@jhelmold jhelmold commented Jan 23, 2024

What

The Vulnerability Report PDF had in special cases only a length of zero bytes (it was empty) when sent by an alert. This is no longer the case.

Why

This is a bug-fix.

References

GEA-408

Checklist

Tested manually on my development system

  • Tests

@jhelmold jhelmold requested review from mattmundell and a team as code owners January 23, 2024 10:17
Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like something the PDF generator should be able to handle, but nice to have the excerpt attribute consistently there.

Would be good if you could do the same for notes.

src/gmp.c Outdated Show resolved Hide resolved
src/gmp.c Outdated Show resolved Hide resolved
@jhelmold jhelmold marked this pull request as draft January 24, 2024 12:46
@jhelmold jhelmold closed this Jan 29, 2024
@timopollmeier timopollmeier deleted the GEA-408_Zero_byte_Vulnerability_Report_PDF branch September 27, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants