Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Outdated 21.04 link in Feed Sync Notification. #4230

Closed
wants to merge 1 commit into from

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Nov 25, 2024

What

Introduced in #4120 and currently pointing at a dead / 404 link as the GOS 21.04 documentation is no longer available.

Why

Obvious...

References

None

@cfi-gb cfi-gb requested a review from a team as a code owner November 25, 2024 10:55
Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.68%. Comparing base (b42f1d8) to head (77e2b30).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4230   +/-   ##
=======================================
  Coverage   62.68%   62.68%           
=======================================
  Files        1111     1111           
  Lines       98795    98795           
  Branches     6497     6497           
=======================================
  Hits        61931    61931           
  Misses      36733    36733           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bjoernricks
Copy link
Contributor

@cfi-gb could you update the failing test case too?

@y0urself
Copy link
Member

y0urself commented Jan 3, 2025

@cfi-gb Also please consider using a feature branch instead of a fork, otherwise the PR is not mergable, due to failing CI. Thank you.

@cfi-gb
Copy link
Member Author

cfi-gb commented Jan 7, 2025

  • Test case failure seems to be completely unrelated as i haven't touched anything on e.g. the footer / copyright year
  • AFAICT i don't have any permission to create a feature branch and usually this shouldn't be required at all (remember, there are also 3rd party contributors)

As this PR is already way too long open and is causing too much overhead for such a minor change @greenbone/gsa-maintainers please take over and fix the link on your own in a separate PR (maybe also directly point to the 24.04 docs once available).

@cfi-gb cfi-gb closed this Jan 7, 2025
auto-merge was automatically disabled January 7, 2025 07:30

Pull request was closed

@cfi-gb
Copy link
Member Author

cfi-gb commented Jan 24, 2025

It seems this got handled in #4289 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants