Add confirmation dialog for bulk trashcan or delete table action #4123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An instance variable stores the value directly and doesn't cause re-renders if it is changed. Variables returned from this hooks are comparable to instance variables for class components.
The dependency review workflow is able to write a summary message to the PR if it is allowed to write to the workflow.
The useShallowEqualSelector hooks allows to avoid re-renders if an object is selected from the redux store but its value(s) didn't change. With the standard selector which uses `===` comparison even updating an object's value to the same value will cause a re-render (because a new state object is created). This pattern can be found at https://react-redux.js.org/api/hooks#recipe-useshallowequalselector
The new usePageFilter hook allows to get the current applied filter of a page from the redux store.
Update the usePageFilter hook to add additional functions to change, reset and remove a page filter.
The selectors where invented for usage with mapStateToProps therefore they return objects at the moment. To avoid unnecessary re-renders the returned objects need to be compared with shallow equal.
At the end FilterProvider should be replaced with usePageFilter completely.
Allow for better reading flow where variables and hooks are defined at the top.
* Add: CVSS 4.0 Calculator * Add: test for CvssV4Point0Calculator * Apply: review comments * Add: German translations
Add a new hooks that allows to get the previous value after the value is changed. For example this hook can be used to check whether a filter has changed.
CVSS 4.0 metrics can now be displayed in CVE details.
for translation and consistency with the calculator.
Support CVSS 4.0 fields in CVEs.
The hook can be used to run a function after a specific amount of time for example for doing a reload of data.
* Change: withIconSize HOC to hook * add tests * improve test coverage * remove snapshot test
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…s-3.0.3 Bump braces from 3.0.2 to 3.0.3
The new useReload hook is based in useTiming. It calls a timing function before every reload to calculate the timeout before the reload. This timing function gets a isVisible argument passed. Using the argument the timing function can decide to extend the timeout when the current browser window is not visible.
The hook determines the sort field and direction of a filter and allows to change both via a returned function. The hook can be used to implement the filter changes when clicking on the different header columns of a entities list.
The hook returns functions the update a filter for getting the next, previous, first and last page for a list of entities.
The useSelection hook implements the entity selection at a entities list table. It is possible to select/deselect specific entities from the list/table, to select all entities displayed at the page or all entities for the current filter (filter without rows value applied).
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Manifest Filespackage-lock.json
package.json
|
Conventional Commits Report
🚀 Conventional commits found. |
Update footer.jsx Update footer.jsx
daniele-mng
force-pushed
the
ADD-confirmation-dialog-for-bulk-trashcan-or-delete
branch
from
11e512e to
97553b2
Compare
daniele-mng
force-pushed
the
rebase-opensight-ui
branch
2 times, most recently
from
acd7f33 to
0334c01
Compare
a-h-abdelsalam
requested changes
Aug 22, 2024
a-h-abdelsalam
previously approved these changes
Aug 23, 2024
daniele-mng
dismissed
a-h-abdelsalam’s stale review
The base branch was changed.
timopollmeier
deleted the
ADD-confirmation-dialog-for-bulk-trashcan-or-delete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
References
GEA-412
Checklist