Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonicalize all general reacts hooks in hooks directory #4076

Merged
merged 7 commits into from
Jun 20, 2024
Merged

Conversation

bjoernricks
Copy link
Contributor

What

Put all general react hooks in the src/web/hooks directory.

Why

Before, some hooks where present in the src/web/utils directory side by side to their HOC counterparts but new hooks were placed into src/web/hooks. To have a common directory for all general hooks src/web/hooks is used now.

Checklist

  • Tests

@bjoernricks bjoernricks requested a review from a team as a code owner June 19, 2024 10:09
@bjoernricks bjoernricks enabled auto-merge (rebase) June 19, 2024 10:09
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA c4f8dcc.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

Conventional Commits Report

Type Number
Changed 6
Removed 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.32%. Comparing base (5d09434) to head (c4f8dcc).

Files Patch % Lines
src/web/pages/nvts/details.jsx 75.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4076      +/-   ##
==========================================
- Coverage   72.33%   72.32%   -0.02%     
==========================================
  Files        1068     1067       -1     
  Lines      122256   122228      -28     
  Branches     6059     6057       -2     
==========================================
- Hits        88438    88404      -34     
- Misses      33787    33793       +6     
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjoernricks bjoernricks merged commit c4542fd into main Jun 20, 2024
13 checks passed
@bjoernricks bjoernricks deleted the move-hooks branch June 20, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants