Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Toggle to enable EPSS fields #4048

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Add: Toggle to enable EPSS fields #4048

merged 5 commits into from
Jun 18, 2024

Conversation

timopollmeier
Copy link
Member

What

The EPSS fields for CVEs and VTs can now be toggled with an option in the config.js file.

Why

This is done because no EPSS feed is provided yet, so the new fields should only be enabled for testing.

References

GEA-571

Checklist

  • Tests

Copy link

github-actions bot commented Jun 5, 2024

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.46%. Comparing base (e9a1b84) to head (51eb857).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4048   +/-   ##
=======================================
  Coverage   72.45%   72.46%           
=======================================
  Files        1067     1067           
  Lines      121990   122030   +40     
  Branches     6050     6060   +10     
=======================================
+ Hits        88385    88425   +40     
  Misses      33574    33574           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timopollmeier timopollmeier marked this pull request as ready for review June 5, 2024 09:48
@timopollmeier timopollmeier requested a review from a team as a code owner June 5, 2024 09:48
Copy link

github-actions bot commented Jun 11, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 51eb857.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new setting should be documented in the README too.

The EPSS fields for CVEs and VTs can now be toggled with an option in
the config.js file.

This is done because no EPSS feed is provided yet, so the new fields
should only be enabled for testing.
A superfluous fragment has been removed and consts are used for
the EPSS scores and percentiles in tables for better readability.
@timopollmeier timopollmeier merged commit f955c28 into main Jun 18, 2024
13 checks passed
@timopollmeier timopollmeier deleted the add-epss-toggle branch June 18, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants