Fix: Don't display loading error on trashcan page if an error occurred #3993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
bjoernricks
force-pushed
the
stop-loading-on-error-at-trashcan-page
branch
2 times, most recently
from
4fc9e79 to
913a3e3
Compare
Deactivate the loading indicator if an error occurred while loading the trashcan data. This change also cleans up the loading code a bit.
Hooks are much easier to understand then HOCs.
a-h-abdelsalam
force-pushed
the
stop-loading-on-error-at-trashcan-page
branch
from
913a3e3 to
0ec9bf2
Compare
a-h-abdelsalam
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Don't display loading error on trashcan page if an error occurred
Why
Deactivate the loading indicator if an error occurred while loading the trashcan data. This change also cleans up the loading code a bit.