Change: Allow to set a filter type to create in withFilterDialog #3992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
a-h-abdelsalam
approved these changes
Apr 4, 2024
With this change it is possible to define the filter type to use when a
new filter is created directly when writing a filter dialog component.
Before it was required to pass it via a prop. Passing via a prop is
still optional.
Example usage now (implicitly):
```
createFilterDialog({
createFilterType: 'portlist',
sortFields: SORT_FIELDS,
});
```
a-h-abdelsalam
force-pushed
the
with-filter-dialog-filter-type
branch
from
10d440a to
b26749e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow to set a filter type to create in withFilterDialog
Why
With this change it is possible to define the filter type to use when a new filter is created directly when writing a filter dialog component. Before it was required to pass it via a prop. Passing via a prop is still optional.
Example usage now (implicitly):