Fix "Error: Not implemented: navigation (except hash changes)" during tests #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report😢 No conventional commits found. 👉 Learn more about the conventional commits usage at Greenbone. |
bjoernricks
force-pushed
the
fix-navigation-error-during-tests
branch
from
8b869e0 to
70c9825
Compare
… tests JSDOM doesn't implement the navigation API and therefore raises an error in the console if `window.location` is used and anchors are clicked. As we are using a lot of anchors in our pages this error is raised often during test runs. By mocking the HTMLAnchorElement click handler the console error is silenced.
bjoernricks
force-pushed
the
fix-navigation-error-during-tests
branch
from
70c9825 to
c602bc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix "Error: Not implemented: navigation (except hash changes)" during tests
Why
JSDOM doesn't implement the navigation API and therefore raises an error in the console if
window.locationis used and anchors are clicked. As we are using a lot of anchors in our pages this error is raised often during test runs. By mocking the HTMLAnchorElement click handler the console error is silenced.