Change: Disable start icon for tasks with duration limit #3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a task has a schedule with a duration limit assigned, the start icon will be disabled. This is done because there is currently no distinction between a scheduled start and a manual one, so the schedule would often stop the task immediately.
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3918 +/- ##
=======================================
Coverage 59.98% 59.99%
=======================================
Files 1023 1023
Lines 25173 25177 +4
Branches 7470 7473 +3
=======================================
+ Hits 15100 15104 +4
Misses 9125 9125
Partials 948 948 ☔ View full report in Codecov by Sentry. |
bjoernricks
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
If a task has a schedule with a duration limit assigned, the start icon will be disabled.
Why
This is done because there is currently no distinction between a scheduled start and a manual one, so the schedule would often stop the task immediately.
References
GEA-379
Checklist