Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Show status information for container tasks and reports #3916

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

a-h-abdelsalam
Copy link
Contributor

@a-h-abdelsalam a-h-abdelsalam commented Nov 13, 2023

What

Container tasks now show "Processing" when uploading reports or creating assets and show "Interrupted" when upload is interrupted. Reports show "Uploading" during upload and "Interrupted" if upload is interrupted.

Why

If a report is uploaded to a container task it will appear done (with the "Container" status in GSA) once it is in the phase of processing the assets. This can be misleading, especially if the processing takes a long time, as is the case for uploading multiple larger reports.

References

GEA-353

@a-h-abdelsalam a-h-abdelsalam requested a review from a team as a code owner November 13, 2023 17:39
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@a-h-abdelsalam a-h-abdelsalam marked this pull request as draft November 14, 2023 08:17
a-h-abdelsalam and others added 2 commits November 14, 2023 09:31
Container tasks now show "processing" when uploading reports or
creating assets and show "interrupted" when upload is interrupted.
Reports show "uploading" during upload  and "interrupted" if
upload is interrupted.
Co-authored-by: Timo Pollmeier <[email protected]>
@a-h-abdelsalam a-h-abdelsalam force-pushed the update-container-task-status branch from 84e1168 to 765c20e Compare November 14, 2023 08:31
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (177128e) 59.98% compared to head (765c20e) 59.98%.

Files Patch % Lines
src/web/pages/reports/row.js 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3916   +/-   ##
=======================================
  Coverage   59.98%   59.98%           
=======================================
  Files        1023     1023           
  Lines       25165    25173    +8     
  Branches     7462     7470    +8     
=======================================
+ Hits        15094    15100    +6     
- Misses       9123     9125    +2     
  Partials      948      948           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-h-abdelsalam a-h-abdelsalam marked this pull request as ready for review November 14, 2023 08:46
@timopollmeier timopollmeier merged commit 41deb65 into main Nov 14, 2023
13 checks passed
@timopollmeier timopollmeier deleted the update-container-task-status branch November 14, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants