Fix: Fix invalid DOM props and other minor JS console errors #3915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes various minor errors that do not visibly affect the content visible to users but appear in the JS console. This includes: - internal props are no longer passed to the DOM - invalid prop types are fixed - better handling of models and missing data - tr elements are nested in the correct parent elements - keys in reference lists are made unique - correct functions are defined for gmp mock in tests Fixing these errors makes it easier to spot errors that do have an effect on the visible content.
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report
@@ Coverage Diff @@
## main #3915 +/- ##
==========================================
+ Coverage 59.95% 59.97% +0.02%
==========================================
Files 1022 1023 +1
Lines 25137 25163 +26
Branches 7452 7462 +10
==========================================
+ Hits 15070 15092 +22
- Misses 9119 9123 +4
Partials 948 948
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
bjoernricks
reviewed
Nov 10, 2023
There was a problem hiding this comment.
Really nice! Something I would loved to be fixed years ago already.
Maybe make it even simpler to exclude props by adding something like
const styledExcludeProps = (styledComponent, excludedProps) => styledComponent.withConfig(
excludePropsConfig(excludedProps)
);usage
styledExcludeProps(styled.div`
...
`, ["foo", "bar"])
bjoernricks
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes various minor errors that do not visibly affect the content visible to users but appear in the JS console.
This includes:
Why
Fixing these errors makes it easier to spot errors that do have an effect on the visible content.
References
GEA-350
Checklist