Change: Show extra details for report TLS certificates #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report
@@ Coverage Diff @@
## main #3913 +/- ##
==========================================
- Coverage 59.95% 59.95% -0.01%
==========================================
Files 1022 1022
Lines 25132 25125 -7
Branches 7439 7443 +4
==========================================
- Hits 15068 15063 -5
+ Misses 9116 9114 -2
Partials 948 948
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
bjoernricks
reviewed
Nov 3, 2023
The first column now shows subject_dn instead of issuer_dn and the certificate entries are now expandable to show extra details such as issuer_dn, sha256_fingerprint, md5_fingerprint and valid.
a-h-abdelsalam
force-pushed
the
show-subject-in-tls-tab-for-reports
branch
from
cc3f6eb to
c334cbd
Compare
timopollmeier
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Show extra details for report TLS certificates. The first column now shows
subject_dninstead ofissuer_dnand the certificate entries are now expandable to show extra details includingissuer_dn,sha256_fingerprint,md5_fingerprintandvalid.Why
To make the behavior consistent with the TLS certificate assets page.
References
GEA-308
Checklist