Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: Removed the logic for the client certificates credential type. #3903

Merged
merged 8 commits into from
Dec 8, 2023

Conversation

jhelmold
Copy link
Member

@jhelmold jhelmold commented Oct 20, 2023

What

The client certificates credential type logic has been removed.

The credentials of type "client certificate" are not touched and can still be accessed. But they
are of no use anymore. They can be deleted manually.

Why

The client certificates credential type was once used for (custom) OSP scanners,
a functionality that was removed with GOS 22.04.0. So it is not used any more and
it confused the users.

References

GEA-333

Checklist

Manually tested on my development environment.

  • Tests

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Conventional Commits Report

Type Number
Removed 1

🚀 Conventional commits found.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6ade928) 59.99% compared to head (14bdbce) 59.95%.
Report is 1 commits behind head on main.

❗ Current head 14bdbce differs from pull request most recent head bc6d746. Consider uploading reports for the commit bc6d746 to get more accurate results

Files Patch % Lines
src/web/pages/scanners/component.js 0.00% 3 Missing ⚠️
src/web/pages/scanners/detailspage.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3903      +/-   ##
==========================================
- Coverage   59.99%   59.95%   -0.05%     
==========================================
  Files        1023     1022       -1     
  Lines       25174    25108      -66     
  Branches     7471     7438      -33     
==========================================
- Hits        15104    15053      -51     
+ Misses       9124     9110      -14     
+ Partials      946      945       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhelmold jhelmold marked this pull request as ready for review October 26, 2023 09:02
@jhelmold jhelmold requested a review from a team as a code owner October 26, 2023 09:02
@timopollmeier timopollmeier force-pushed the GEA-333_Remove_client_certificate_logic branch from 4c7671d to 48c0733 Compare October 31, 2023 07:41
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some parts of the code made obsolete by the removal that can still be cleaned up while in the tests there are still parts that should not have been removed, but adjusted to the changed credential type instead.

src/web/pages/credentials/__tests__/dialog.js Outdated Show resolved Hide resolved
src/web/pages/credentials/__tests__/dialog.js Show resolved Hide resolved
src/web/pages/scanners/dialog.js Outdated Show resolved Hide resolved
src/web/pages/scanners/dialog.js Outdated Show resolved Hide resolved
@jhelmold jhelmold force-pushed the GEA-333_Remove_client_certificate_logic branch from 430fde3 to 8f451db Compare November 3, 2023 13:27
@jhelmold jhelmold marked this pull request as draft November 3, 2023 15:09
@jhelmold jhelmold self-assigned this Nov 3, 2023
@jhelmold jhelmold marked this pull request as ready for review November 6, 2023 09:21
@timopollmeier timopollmeier force-pushed the GEA-333_Remove_client_certificate_logic branch from 8c209a7 to 14bdbce Compare November 10, 2023 08:40
@timopollmeier timopollmeier force-pushed the GEA-333_Remove_client_certificate_logic branch from 14bdbce to bc6d746 Compare December 8, 2023 09:02
@timopollmeier timopollmeier merged commit db5576a into main Dec 8, 2023
11 checks passed
@timopollmeier timopollmeier deleted the GEA-333_Remove_client_certificate_logic branch December 8, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants