-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove: Removed the logic for the client certificates credential type. #3903
Conversation
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3903 +/- ##
==========================================
- Coverage 59.99% 59.95% -0.05%
==========================================
Files 1023 1022 -1
Lines 25174 25108 -66
Branches 7471 7438 -33
==========================================
- Hits 15104 15053 -51
+ Misses 9124 9110 -14
+ Partials 946 945 -1 ☔ View full report in Codecov by Sentry. |
4c7671d
to
48c0733
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some parts of the code made obsolete by the removal that can still be cleaned up while in the tests there are still parts that should not have been removed, but adjusted to the changed credential type instead.
430fde3
to
8f451db
Compare
8c209a7
to
14bdbce
Compare
This credential type was once used for (custom) OSP scanners, a functionality that was removed with GOS 22.04.0.
14bdbce
to
bc6d746
Compare
What
The client certificates credential type logic has been removed.
The credentials of type "client certificate" are not touched and can still be accessed. But they
are of no use anymore. They can be deleted manually.
Why
The client certificates credential type was once used for (custom) OSP scanners,
a functionality that was removed with GOS 22.04.0. So it is not used any more and
it confused the users.
References
GEA-333
Checklist
Manually tested on my development environment.