Fix: Don't mutate a Filter instance #4318
ci-js.yml
on: pull_request
Matrix: Upload coverage
Matrix: Linting
Matrix: Run tests
Annotations
5 errors and 4 warnings
src/web/hooks/__tests__/usePageFilter.jsx > usePageFilter tests > should prefer pageFilter over defaultSettingFilter:
src/web/hooks/__tests__/usePageFilter.jsx#L89
AssertionError: expected Filter{ entityType: 'filter', …(3) } to deeply equal Filter{ entityType: 'filter', …(1) }
- Expected
+ Received
Filter {
"entityType": "filter",
+ "filter_type": undefined,
+ "id": undefined,
"terms": Array [
FilterTerm {
"keyword": "page",
"relation": "=",
"value": "filter",
+ },
+ FilterTerm {
+ "keyword": "rows",
+ "relation": "=",
+ "value": 42,
},
],
}
❯ src/web/hooks/__tests__/usePageFilter.jsx:89:31
|
Run tests (20)
Process completed with exit code 1.
|
Run tests (18)
The job was canceled because "_20" failed.
|
Run tests (18)
The operation was canceled.
|
Upload coverage (18)
Process completed with exit code 1.
|
Linting (20)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Linting (18)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Run tests (20)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Upload coverage (18)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
linting-report-18
|
204 Bytes |
|
linting-report-20
|
204 Bytes |
|