Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback MQTT removal - Add MQTT installation and config back into source code build guide #475

Closed
wants to merge 2 commits into from

Conversation

syspect-sec
Copy link
Contributor

@syspect-sec syspect-sec commented May 22, 2024

What

MQTT installation and configuration was removed from the source code build guide, but it is still required until further changes to ospd-openvas.

References

https://forum.greenbone.net/t/openvas-executable-not-available/17944

Checklist

@syspect-sec syspect-sec requested a review from a team as a code owner May 22, 2024 05:02
@greenbonebot greenbonebot enabled auto-merge (rebase) May 22, 2024 05:03
@bjoernricks bjoernricks changed the title Rollback MQQT removal - Add MQTT installation and config back into source code build guide Rollback MQTT removal - Add MQTT installation and config back into source code build guide May 22, 2024
@nichtsfrei
Copy link
Member

nichtsfrei commented May 23, 2024

As of version 22.7.1 ospd-openvas does check if openvasd_server is configured within openvas and if so disables MQTT.
This is also mentioned in the documentation with the step:

printf "openvasd_server = http://127.0.0.1:3000\n" | sudo tee -a /etc/openvas/openvas.conf

in https://greenbone.github.io/docs/latest/22.4/source-build/index.html#openvas-scanner.

From that understanding I fail to see why the MQTT installation and configuration should be added to the documentation.

The linked reference has the issue that ospd-openvas is not able to find the executable openvas in PATH.

@cfi-gb
Copy link
Member

cfi-gb commented Jul 24, 2024

As of version 22.7.1 ospd-openvas does check if openvasd_server is configured within openvas and if so disables MQTT.

It has been pointed out in https://forum.greenbone.net/t/the-version-of-ospd-openvas-in-community-doc-is-error/18761 that this might be the culprit.

As of today the documentation in https://greenbone.github.io/docs/latest/22.4/source-build/index.html#ospd-openvas is telling the user to install an older 22.6.2 version:

export OSPD_OPENVAS_VERSION=22.6.2

Could this be closed and the versions like above bumped to the most recent version instead to solve this?

@k-schlosser
Copy link
Contributor

Could this be closed and the versions like above bumped to the most recent version instead to solve this?

I opened #494 to address this.

Let me know if this means that this PR (#475) can be closed.

@cfi-gb
Copy link
Member

cfi-gb commented Jul 26, 2024

Unfortunately i'm not able to tell if this is actually solving the problem, only forwarded this info (which now also ended up in #492) from another user.

Not sure as well if only bumping the version of ospd-openvas should be done, seems all versions haven't been bumped in the docs since quite some while (e.g. gsad is at 22.9.0 from January 2024 with three releases in between and the current version gsad 22.11.0).

@k-schlosser
Copy link
Contributor

Closing here because the versions of ospd-openvas and openvas-scanner have been bumped to the most recent versions, see #494

auto-merge was automatically disabled July 26, 2024 09:42

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants