Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] QueryRowCount metric #10964

Open
wants to merge 5 commits into
base: f/gx-43/add-column-values-metric
Choose a base branch
from

Conversation

NathanFarmer
Copy link
Contributor

Add QueryRowCount metric

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

@NathanFarmer NathanFarmer self-assigned this Feb 24, 2025
Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 0cabc93
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/67bcc7e1ff87580008bf943f

@NathanFarmer NathanFarmer changed the base branch from develop to f/gx-43/add-column-values-metric February 24, 2025 19:27
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.25%. Comparing base (755b5a1) to head (24ea694).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           f/gx-43/add-column-values-metric   #10964      +/-   ##
====================================================================
- Coverage                             80.84%   80.25%   -0.60%     
====================================================================
  Files                                   472      473       +1     
  Lines                                 40809    40818       +9     
====================================================================
- Hits                                  32992    32757     -235     
- Misses                                 7817     8061     +244     
Flag Coverage Δ
3.10 70.25% <100.00%> (+0.02%) ⬆️
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.67% <100.00%> (+0.01%) ⬆️
3.10 aws_deps 46.53% <100.00%> (+0.01%) ⬆️
3.10 big 54.97% <100.00%> (+<0.01%) ⬆️
3.10 bigquery 48.89% <100.00%> (+0.01%) ⬆️
3.10 clickhouse 43.44% <100.00%> (+0.01%) ⬆️
3.10 databricks 50.65% <100.00%> (+0.01%) ⬆️
3.10 filesystem 63.02% <100.00%> (+<0.01%) ⬆️
3.10 mssql 51.64% <100.00%> (+0.01%) ⬆️
3.10 mysql 51.91% <100.00%> (+0.01%) ⬆️
3.10 postgresql 54.64% <100.00%> (+0.01%) ⬆️
3.10 snowflake 51.40% <100.00%> (+0.01%) ⬆️
3.10 spark 57.96% <100.00%> (+0.01%) ⬆️
3.10 spark_connect 46.84% <100.00%> (+0.01%) ⬆️
3.10 trino 52.45% <100.00%> (+0.01%) ⬆️
3.11 70.23% <100.00%> (+<0.01%) ⬆️
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.67% <100.00%> (+0.01%) ⬆️
3.11 aws_deps 46.53% <100.00%> (+0.01%) ⬆️
3.11 big 54.97% <100.00%> (+<0.01%) ⬆️
3.11 bigquery 48.89% <100.00%> (+0.01%) ⬆️
3.11 clickhouse 43.44% <100.00%> (+0.01%) ⬆️
3.11 databricks 50.65% <100.00%> (+0.01%) ⬆️
3.11 filesystem 63.02% <100.00%> (+<0.01%) ⬆️
3.11 mssql 51.64% <100.00%> (+0.01%) ⬆️
3.11 mysql 51.91% <100.00%> (+0.01%) ⬆️
3.11 postgresql 54.64% <100.00%> (+0.01%) ⬆️
3.11 snowflake 51.40% <100.00%> (+0.01%) ⬆️
3.11 spark 57.96% <100.00%> (+0.01%) ⬆️
3.11 spark_connect 46.84% <100.00%> (+0.01%) ⬆️
3.11 trino 52.45% <100.00%> (+0.01%) ⬆️
3.12 70.25% <100.00%> (+<0.01%) ⬆️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.68% <100.00%> (+0.01%) ⬆️
3.12 aws_deps 46.53% <100.00%> (+0.01%) ⬆️
3.12 big 54.97% <100.00%> (+<0.01%) ⬆️
3.12 bigquery 48.89% <100.00%> (+0.01%) ⬆️
3.12 databricks 50.66% <100.00%> (+0.01%) ⬆️
3.12 filesystem 63.02% <100.00%> (+<0.01%) ⬆️
3.12 mssql 51.64% <100.00%> (+0.01%) ⬆️
3.12 mysql 51.91% <100.00%> (+0.01%) ⬆️
3.12 postgresql 54.65% <100.00%> (+0.01%) ⬆️
3.12 snowflake 51.40% <100.00%> (+0.01%) ⬆️
3.12 spark 57.96% <100.00%> (+0.01%) ⬆️
3.12 spark_connect 46.85% <100.00%> (+0.01%) ⬆️
3.12 trino 52.45% <100.00%> (+0.01%) ⬆️
3.9 70.27% <100.00%> (+<0.01%) ⬆️
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.67% <100.00%> (+0.01%) ⬆️
3.9 aws_deps 46.55% <100.00%> (+0.01%) ⬆️
3.9 big 54.98% <100.00%> (+<0.01%) ⬆️
3.9 bigquery 48.88% <100.00%> (+0.01%) ⬆️
3.9 clickhouse 43.45% <100.00%> (+0.01%) ⬆️
3.9 databricks 50.65% <100.00%> (+0.01%) ⬆️
3.9 filesystem 63.03% <100.00%> (+<0.01%) ⬆️
3.9 mssql 51.62% <100.00%> (+0.01%) ⬆️
3.9 mysql 51.89% <100.00%> (+0.01%) ⬆️
3.9 postgresql 54.63% <100.00%> (+0.01%) ⬆️
3.9 snowflake 51.40% <100.00%> (+0.01%) ⬆️
3.9 spark 57.92% <100.00%> (+0.01%) ⬆️
3.9 spark_connect 46.86% <100.00%> (+0.01%) ⬆️
3.9 trino 52.44% <100.00%> (+0.01%) ⬆️
cloud 0.00% <0.00%> (ø)
docs-basic ?
docs-creds-needed ?
docs-spark ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant