Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove batch_id from Metric classes #10962

Draft
wants to merge 2 commits into
base: f/gx-42/metric-api-aggregate-metric
Choose a base branch
from

Conversation

billdirks
Copy link
Contributor

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

codecov bot commented Feb 22, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2829 1 2828 261
View the top 1 failed test(s) by shortest run time
tests.metrics.test_domain.TestColumnValues::test_arguments_empty_string_raises[kwargs0]
Stack Traces | 0.004s run time
self = <tests.metrics.test_domain.TestColumnValues object at 0x7fcdf655dc10>
kwargs = {'batch_id': '', 'column': 'my_column'}

    @pytest.mark.unit
    @pytest.mark.parametrize(
        "kwargs",
        [
            {"batch_id": "", "column": COLUMN},
            {"batch_id": BATCH_ID, "column": ""},
        ],
    )
    def test_arguments_empty_string_raises(self, kwargs: dict):
>       with pytest.raises(ValidationError) as e:
E       Failed: DID NOT RAISE <class 'pydantic.v1.error_wrappers.ValidationError'>

tests/metrics/test_domain.py:42: Failed

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants