[FEATURE] Add mean to metrics API #10961
Open
+117
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10961 +/- ##
===========================================
- Coverage 80.84% 78.45% -2.39%
===========================================
Files 471 472 +1
Lines 40790 40797 +7
===========================================
- Hits 32976 32008 -968
- Misses 7814 8789 +975
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
billdirks
commented
Feb 21, 2025
| batch_setup = request.getfixturevalue(setup_datasource) | ||
| breakpoint() | ||
| with batch_setup.batch_test_context() as batch: | ||
| metric = ColumnValuesMean(batch_id=batch.id, column="number") |
There was a problem hiding this comment.
I will file a ticket to remove the batch_id argument when instantiating a metric.
There was a problem hiding this comment.
NathanFarmer
requested changes
Feb 24, 2025
Comment on lines
+45
to
+51
| @pytest.fixture | ||
| def setup_spark(dataframe: pandas.DataFrame, tmp_path: Path) -> SparkFilesystemCsvBatchTestSetup: | ||
| return SparkFilesystemCsvBatchTestSetup( | ||
| config=SparkFilesystemCsvDatasourceTestConfig(), | ||
| data=dataframe, | ||
| base_dir=tmp_path, | ||
| ) |
There was a problem hiding this comment.
You may need to pass column_types to SparkFilesystemCsvDatasourceTestConfig to get the spark error test passing. Maybe it is coercing somehow, I'm not sure why it doesn't fail.
There was a problem hiding this comment.
It looks to be a bug and we use a different metric name when the mean fails on spark. See inline comment on failure test below.
billdirks
commented
Feb 25, 2025
|
|
||
|
|
||
| @pytest.fixture | ||
| def setup_snowflake(dataframe: pandas.DataFrame) -> SnowflakeBatchTestSetup: |
There was a problem hiding this comment.
I've added snowflake tests since it is already supported in expectai.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke lint(usesruff format+ruff check)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!