Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Tests need to opt into running snowflake tests #10605

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tyler-hoffman
Copy link
Contributor

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 395bbd6
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/678fad9663371a00072adab7

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (3ca5f4a) to head (395bbd6).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10605      +/-   ##
===========================================
- Coverage    80.72%   80.63%   -0.09%     
===========================================
  Files          465      465              
  Lines        40554    40554              
===========================================
- Hits         32737    32702      -35     
- Misses        7817     7852      +35     
Flag Coverage Δ
3.10 70.02% <ø> (ø)
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 clickhouse ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 spark_connect ?
3.10 trino ?
3.11 70.02% <ø> (ø)
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 clickhouse ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 spark_connect ?
3.11 trino ?
3.12 70.02% <ø> (ø)
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.39% <ø> (ø)
3.12 aws_deps 46.26% <ø> (ø)
3.12 big 54.78% <ø> (ø)
3.12 bigquery 48.53% <ø> (ø)
3.12 databricks 50.29% <ø> (ø)
3.12 filesystem 62.77% <ø> (ø)
3.12 mssql 51.29% <ø> (ø)
3.12 mysql 51.70% <ø> (ø)
3.12 postgresql 54.34% <ø> (ø)
3.12 snowflake 43.03% <ø> (-8.06%) ⬇️
3.12 spark 57.67% <ø> (ø)
3.12 spark_connect 46.54% <ø> (ø)
3.12 trino 52.25% <ø> (ø)
3.9 70.05% <ø> (ø)
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.39% <ø> (ø)
3.9 aws_deps 46.28% <ø> (ø)
3.9 big 54.79% <ø> (ø)
3.9 bigquery 48.52% <ø> (ø)
3.9 clickhouse 43.17% <ø> (ø)
3.9 databricks 50.29% <ø> (+<0.01%) ⬆️
3.9 filesystem 62.77% <ø> (ø)
3.9 mssql 51.27% <ø> (ø)
3.9 mysql 51.68% <ø> (ø)
3.9 postgresql 54.33% <ø> (ø)
3.9 snowflake 43.05% <ø> (-8.05%) ⬇️
3.9 spark 57.63% <ø> (ø)
3.9 spark_connect 46.55% <ø> (ø)
3.9 trino 52.23% <ø> (ø)
cloud 0.00% <ø> (ø)
docs-basic 53.90% <ø> (ø)
docs-creds-needed 52.84% <ø> (ø)
docs-spark 52.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tyler-hoffman tyler-hoffman requested a review from a team November 4, 2024 18:18
Copy link
Member

@joshua-stauffer joshua-stauffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tyler-hoffman tyler-hoffman added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants