feat(design): create DaffOpenableDirective
#2908
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xelaint
added
package: design
xelaint
changed the title
DaffOpenable interface
xelaint
added
status: wip
xelaint
force-pushed
the
openable-interface
branch
from
439e580
to
591fb30
Compare
xelaint
added
status: awaiting review
|
@damienwebdev Need to finalize what the output naming is for the openable directive. Are we sticking to |
xelaint
force-pushed
the
openable-interface
branch
from
591fb30
to
3332f41
Compare
xelaint
changed the title
DaffOpenable interfaceDaffOpenableDirective
damienwebdev
requested changes
Jul 29, 2024
xelaint
force-pushed
the
openable-interface
branch
from
3332f41
to
8a7d0b2
Compare
|
@griest024 we made some updates according to your concerns. lmk what you think. |
griest024
requested changes
Aug 27, 2024
griest024
requested changes
Sep 3, 2024
| hide: () => void; | ||
|
|
||
| /** Sets toggle on the component */ | ||
| /** Toggles the component from open to not open */ |
There was a problem hiding this comment.
This will also work in reverse from not open to open, correct? The comment should reflect that converse behavior.
| /** Whether or not a component implementing the directive is open */ | ||
| @Input() @HostBinding('class.daff-open') open = false; | ||
|
|
||
| private _setOpen(v: boolean) { | ||
| if(!this.stateless) { | ||
| this.open = v; |
There was a problem hiding this comment.
this should be mutating this._open not this.open. The setter for this.open contains the opposite check for stateless so this will never do anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Part of: #763
What is the new behavior?
Does this PR introduce a breaking change?
Other information