incremental: maintain defer fragment ordering #1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as it is used during ExecuteRootSelectionSet
and some baseline collection language for comparison extracted from graphql#742 Authored-by: Rob Richard <[email protected]>
Authored-by: Rob Richard <[email protected]> Co-authored-by: Benjie Gillam <[email protected]> Co-authored-by: Yaacov Rydzinski <[email protected]>
Authored-by: Rob Richard <[email protected]> Co-authored-by: Benjie Gillam <[email protected]> Co-authored-by: Yaacov Rydzinski <[email protected]>
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
pulling this into #1052 based on feedback at graphql/defer-stream-wg#80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1052
Maintains ordering of defers from operation, only sending a child deferred fragment after the parent is sent. By contrast, #1052 will send a deferred fragment once it can be merged into the final reconcilable object.
since it depends on #1052, this is probably the more instructive diff: yaacovCR/graphql-spec@deduplicate3...deduplicate5