v6: Remove editor tab/editor inset padding#4405
Merged
Merged
Conversation
The tab strip and editor area were inset 8px from the column edges to clear the old rounded editor card. That card has been flattened, so the inset just reads as stray whitespace. Remove it so the tabs and editors sit flush against the column edges and the 1px divider.
🦋 Changeset detectedLatest commit: 5c0468a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trevor-scheer
added a commit
that referenced
this pull request
Jul 11, 2026
Reconcile the two-column sessions restructure with the flattened, flush editor frame that landed on graphiql-6 (#4397, #4405): - Drop the 8px inset on `.graphiql-session-row` so the panes sit flush to the frame edges, matching the inset-padding removal (#4405). - Move the editor/response divider `border-right` from `.graphiql-editors` onto `.graphiql-editor-column` so it runs the full column height (header + editor) rather than only the editor body. - Keep `min-height: 0` on `#graphiql-session`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The editor tab strip and editor area sat inset 8px from their column edges. That padding was there to clear the rounded corner of the old editor card, which has since been flattened, so the inset no longer does anything. It just reads as uneven whitespace, most noticeably on the left. This drops it so the tabs and editors sit flush against the column edges and the divider.
Test plan
Refs: #4219