Skip to content

v6: Vertically center the KeycapHint glyph #4400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trevor-scheer merged 1 commit into from
Jul 11, 2026
+12 −1
Merged

v6: Vertically center the KeycapHint glyph #4400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/keycap-hint-vertical-center.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@graphiql/react': patch
---

Vertically center the glyph inside `KeycapHint` keys.
6 changes: 6 additions & 0 deletions packages/graphiql-react/src/components/keycap-hint/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,9 @@
font-weight: 600;
line-height: 1;
}

.graphiql-keycap-glyph {
/* The glyphs' ink sits slightly above the vertical center of their em
box, so centering the line box alone isn't quite enough. */
transform: translateY(0.05em);
}
2 changes: 1 addition & 1 deletion packages/graphiql-react/src/components/keycap-hint/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export const KeycapHint: FC<KeycapHintProps> = ({ keys, ariaLabel }) => {
<span className="graphiql-keycap-hint" aria-label={ariaLabel}>
{keys.map((k, i) => (
<kbd key={`${k}-${i}`} className="graphiql-keycap">
{display[k] ?? k}
<span className="graphiql-keycap-glyph">{display[k] ?? k}</span>
</kbd>
))}
</span>
Expand Down
Loading