v6: Remove the legacy editor toolbar and corner logo#4398
Draft
trevor-scheer wants to merge 7 commits into
Draft
v6: Remove the legacy editor toolbar and corner logo#4398trevor-scheer wants to merge 7 commits into
trevor-scheer wants to merge 7 commits into
Conversation
The v6 layout puts branding in the top bar and editor actions in the tab strip, but the old vertical toolbar and corner logo still rendered alongside them, so prettify and copy appeared twice and a second "GraphiQL" logo floated over the editor. Drop the legacy chrome and move Merge Fragments, which only lived in the old toolbar, into the tab-strip actions so the action isn't lost.
🦋 Changeset detectedLatest commit: 01e9dce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The prettify/merge/copy/save buttons sat at the far right of the tab strip, over the response pane — far from the query you're editing. Split the sessions area into an editor column and a response column divided by the drag bar, and move the tab strip into the editor column so the actions land at the editor's right edge and follow the divider as it's resized.
Reconcile the two-column sessions restructure with the flattened, flush editor frame that landed on graphiql-6 (#4397, #4405): - Drop the 8px inset on `.graphiql-session-row` so the panes sit flush to the frame edges, matching the inset-padding removal (#4405). - Move the editor/response divider `border-right` from `.graphiql-editors` onto `.graphiql-editor-column` so it runs the full column height (header + editor) rather than only the editor body. - Keep `min-height: 0` on `#graphiql-session`.
The editorFlex resize ref moved from .graphiql-editors onto the new .graphiql-editor-column wrapper, so the panel-resizing test now reads flexGrow from the column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Toolbar/Logorender-prop slots still work for embedders. Only the default rendering is removed.Test plan
Refs: #4219