v6: Make the Monaco editors follow the theme toggle#4396
Merged
Conversation
The settings theme toggle only wrote the `data-theme` attribute on the container; the editors kept whatever theme they were given at startup. Route the resolved theme through to `monaco.editor.setTheme` from the same effect that owns `data-theme`, and drop the orphaned setter that was only ever called on init.
🦋 Changeset detectedLatest commit: 6583269 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-themeon the container but never telling Monaco to switch, so the editors stayed on whatever theme they booted with.data-themenow also resolves the theme and callsmonaco.editor.setTheme, so there's one place responsible for both.Test plan
yarn workspace @graphiql/react testpasses, including a new test that assertsmonaco.editor.setThemegets called on theme change.Refs: #4219