fix(graphql-language-service): wrap list input values in brackets on autocomplete#4356
Open
DukeDeSouth wants to merge 1 commit into
Open
fix(graphql-language-service): wrap list input values in brackets on autocomplete#4356DukeDeSouth wants to merge 1 commit into
DukeDeSouth wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: b9aa9aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
…autocomplete Completing an enum or boolean value for a list-typed argument or input field (e.g. `[Episode]`) inserted a bare `JEDI`, which isn't valid there. The online parser already unwraps one list level once the caret is inside a `[ ]`, so the remaining list depth tells us how many brackets to add — this also covers nested lists like `[[Episode]]`. Values typed inside an existing list literal, single (non-list) values and variables are left untouched. Closes graphql#587
DukeDeSouth
force-pushed
the
fix/587-wrap-list-input-values
branch
from
87ff796 to
b9aa9aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing an enum or boolean value at a list-typed position (like
[Episode]) inserts a bareJEDI, so you end up withvalues: JEDIinstead ofvalues: [JEDI]— issue #587. The online parser already unwraps one list level once the caret is inside the brackets, so I count the remaining list depth and add that many brackets; nested lists like[[Episode]]work too. Values typed inside an existing[ ], single non-list values, and variables are left as-is. Added tests across the different positions and nullability combos, plus a changeset.Closes #587