-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an opt-in feature to run multiple queries #1673
Conversation
Hi, I don't quite understand, am i supposed to add relevant comments to the suggested code changes? |
packages/graphiql/README.md
Outdated
- `shouldPersistHeaders`: an optional boolean which enables to persist headers to storage when `true`. Defaults to `false` | ||
- `shouldPersistHeaders`: an optional boolean which enables to persist headers to storage when `true`. Defaults to `false`. | ||
|
||
- `runMultipleQueries`: an optional boolean which enables to run multiple queries when `true`. The actual response of each query is returned as `data` object within the `yourQueryNameData` object. Defaults to `false`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we link this to the spec document? is this what the spec document calls this feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature name is as suggested in the issue. Also I could not find the spec document for graphiql, it would be great if you could share the link!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i mean the spec document for this language feature. in the language spec. can you link to it in the readme here?
packages/graphiql/README.md
Outdated
- `shouldPersistHeaders`: an optional boolean which enables to persist headers to storage when `true`. Defaults to `false` | ||
- `shouldPersistHeaders`: an optional boolean which enables to persist headers to storage when `true`. Defaults to `false`. | ||
|
||
- `runMultipleQueries`: an optional boolean which enables to run multiple queries when `true`. The actual response of each query is returned as `data` object within the `yourQueryNameData` object. Defaults to `false`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i mean the spec document for this language feature. in the language spec. can you link to it in the readme here?
@acao I linked it to the spec doc, let me know if anything else needs to be done. |
4fa9ca3
to
1c11938
Compare
Fixes #1635