Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an opt-in feature to run multiple queries #1673

Closed
wants to merge 2 commits into from
Closed

feat: add an opt-in feature to run multiple queries #1673

wants to merge 2 commits into from

Conversation

siddharthskulkarni
Copy link

Fixes #1635

@siddharthskulkarni
Copy link
Author

Hi I'm not in a hurry to bring detailed comments right now, i'd appreciate it if you'd at least give me 🙂

Hi, I don't quite understand, am i supposed to add relevant comments to the suggested code changes?

- `shouldPersistHeaders`: an optional boolean which enables to persist headers to storage when `true`. Defaults to `false`
- `shouldPersistHeaders`: an optional boolean which enables to persist headers to storage when `true`. Defaults to `false`.

- `runMultipleQueries`: an optional boolean which enables to run multiple queries when `true`. The actual response of each query is returned as `data` object within the `yourQueryNameData` object. Defaults to `false`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we link this to the spec document? is this what the spec document calls this feature?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature name is as suggested in the issue. Also I could not find the spec document for graphiql, it would be great if you could share the link!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean the spec document for this language feature. in the language spec. can you link to it in the readme here?

- `shouldPersistHeaders`: an optional boolean which enables to persist headers to storage when `true`. Defaults to `false`
- `shouldPersistHeaders`: an optional boolean which enables to persist headers to storage when `true`. Defaults to `false`.

- `runMultipleQueries`: an optional boolean which enables to run multiple queries when `true`. The actual response of each query is returned as `data` object within the `yourQueryNameData` object. Defaults to `false`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean the spec document for this language feature. in the language spec. can you link to it in the readme here?

@siddharthskulkarni
Copy link
Author

@acao I linked it to the spec doc, let me know if anything else needs to be done.

@acao acao force-pushed the main branch 6 times, most recently from 4fa9ca3 to 1c11938 Compare February 1, 2021 18:22
@siddharthskulkarni siddharthskulkarni closed this by deleting the head repository Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to run multiple operations (for query batching)
2 participants