Skip to content

Conversation

glen-84
Copy link
Contributor

@glen-84 glen-84 commented Sep 24, 2025

#147 (comment)

Based on an internal discussion:

  1. We'll move this to a pre-merge validation rule.
  2. We'll move the "subscription root fields cannot be shared" part to INVALID_SHAREABLE_USAGE.
  3. We'll update "excluding fields marked with @external or @override" to clarify that it's the overridden field, not the overriding field, that is excluded.
  4. We'll update the spec to require all source schemas to mark the field as shareable, not just one of them.
  5. We'll simplify the counter-example.

Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for composite-schemas ready!

Name Link
🔨 Latest commit fd3c1d9
🔍 Latest deploy log https://app.netlify.com/projects/composite-schemas/deploys/68de7c8702247d0008862ea4
😎 Deploy Preview https://deploy-preview-200--composite-schemas.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@michaelstaib michaelstaib merged commit 88259f9 into graphql:main Oct 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants