Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use explicit clippy version #505

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

caspermeijn
Copy link
Contributor

Using an explicit version of clippy will to prevent CI breaking when new lints are introduced.

Using an explicit version of clippy will to prevent CI breaking when new lints are introduced.
@tomhoule
Copy link
Member

Hi @caspermeijn , thanks for the PR. I'm going to take on slightly more active maintainership on this crate again. I'm split on this — on the one hand, it avoids PRs having to deal with unrelated lint errors after an update. On the other hand, we do want the new lints. I think it's an ok tradeoff to manually update this variable when we want the new lints though, let's do this.

@tomhoule tomhoule merged commit 381d41e into graphql-rust:main Jan 31, 2025
9 checks passed
@caspermeijn caspermeijn deleted the ci_clippy branch February 3, 2025 13:57
@caspermeijn
Copy link
Contributor Author

I agree updating the clippy version is a burden. But I think it is worth it, as a PR opened in one year which fails due to a new clippy lint can be demotivating for a new contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants