Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: root typing use alias when available #477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: root typing use alias when available #477

wants to merge 1 commit into from

Conversation

krazibit
Copy link

@krazibit krazibit commented Aug 5, 2020

root typing use alias when available

@krazibit krazibit mentioned this pull request Aug 5, 2020
Open
jasonkuhrt
jasonkuhrt approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please add a test? Then can merge. Otherwise we'll do it when we can.

jasonkuhrt
jasonkuhrt suggested changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity setting this to changes requested.

@krazibit
Copy link
Author

krazibit commented Aug 6, 2020

Sure, would add a test for it in a bit

@jasonkuhrt
Copy link
Contributor

@krazibit ping

@krazibit
Copy link
Author

sorry @jasonkuhrt , been a bit busy the past weeks, would dedicate some time to add the test over the weekend, cheers

@Sytten
Copy link
Collaborator

Sytten commented Nov 6, 2020

Up!

@jasonkuhrt
Copy link
Contributor

@Weakky @tgriesser do we want this before 1.0?

@Weakky
Copy link
Member

Weakky commented Dec 8, 2020

Yes. I might fix this myself while renaming rootType to sourceType

@jasonkuhrt jasonkuhrt changed the base branch from develop to main December 14, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonkuhrt jasonkuhrt jasonkuhrt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krazibit @jasonkuhrt @Sytten @Weakky